Add code to split blocks and update edges #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris7
approved these changes
Aug 2, 2024
| @@ -38,7 +38,7 @@ CREATE TABLE block ( | |||
| strand TEXT NOT NULL DEFAULT "1", | |||
| FOREIGN KEY(sequence_hash) REFERENCES sequence(hash), | |||
| FOREIGN KEY(block_group_id) REFERENCES block_group(id), | |||
| constraint chk_strand check (strand in ('-1', '1', '0', '.', '?')) | |||
| constraint chk_strand check (strand in ('-1', '1', '0', '.', '?', '+', '-')) | |||
There was a problem hiding this comment.
on the db side, we probably should not use +/- if we have 1/-1
There was a problem hiding this comment.
let's actually drop the -1/1/0 for the gff standards
| chromosome_index: i32, | ||
| phased: i32, | ||
| ) -> Option<(Block, Block)> { | ||
| if coordinate < block.start || coordinate >= block.end { |
There was a problem hiding this comment.
i think we should panic here instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.